ci: fix pre-release gate (release_created is empty, not 'false') - #160
Merged
Conversation
release-please-action sets `release_created` to 'true' or leaves it empty — never the literal 'false'. The prerelease-version job gated on `== 'false'`, so it (and prerelease-build/prerelease-publish) was skipped on every non-release merge to main. Gate on `!= 'true'` instead, which matches both the empty and 'false' cases. Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the first merge after #159 (run 27517243028)
release-pleasesucceeded but no pre-release was built —prerelease-version(andprerelease-build/prerelease-publish) were skipped.Cause
release-please-actionsetsrelease_createdto'true'when it cuts a release and otherwise leaves it empty — it never emits the literal'false'. The pre-release gate was:'' == 'false'is false, so the job never ran on a normal merge. (The same run confirms it:build-release, gated on== 'true', was also correctly skipped — only the== 'false'branch was wrong.)Fix
Gate on
!= 'true', which matches both the empty and'false'cases:Now: normal merge →
release_createdempty → pre-release builds; release-PR merge →release_created == 'true'→ stable builds and the pre-release jobs skip. One-line change; YAML validated.